Copilot commented on code in PR #13704:
URL: https://github.com/apache/trafficserver/pull/13704#discussion_r4041836643
##########
plugins/experimental/cache_fill/configs.cc:
##########
@@ -168,6 +168,10 @@ BgFetchConfig::readConfig(const char *config_file)
continue;
}
++cfg_value; // Drop leading character.
+ if (cfg_value.empty()) {
+ TSError("[%s] missing Content-Length size value, skipping config
value", PLUGIN_NAME);
+ continue;
+ }
Review Comment:
Please add a regression case for a `Content-Length` condition containing
only `<` or `>`. The new guard is not exercised by `cache_fill_range_req_only`,
and the existing analogous `background_fetch` test covers only valid numeric
rules, so a future regression could again install a zero-sized rule without
being detected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
