bryancall commented on PR #13704: URL: https://github.com/apache/trafficserver/pull/13704#issuecomment-5722763551
Thanks — I added the `--cache-range-req=false` case. That was a fair catch: no test in the tree set either option before this, and since the same header lookup drives both, that branch had no coverage at all. It also turns out to be an independent check on this fix rather than just extra breadth — under the broken lookup `hasRangeHdrs` was always false, so `hasRangeHdrs && !_cache_range_req` never ran either. I confirmed that by rebuilding the plugin with the paren restored: the new case fails on its own. While adding it I folded the range-option coverage into the existing `cache_fill.test.py` instead of a separate file, in its own ATS process. It cannot share the existing one, because that test loads `cache_fill` globally with default options, and a global instance hooks every transaction — it would background fill these paths regardless of the per-remap options and make the negative cases vacuous. On coverage for the incomplete `Content-Length` rule: I am leaving that one out deliberately. The only observable behavior is a `TSError` line, so a test for it would assert on a log message and need its own ATS instance for a config-parse path, which I do not think earns its keep here. Noting it so it does not look overlooked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
