maskit commented on code in PR #13719:
URL: https://github.com/apache/trafficserver/pull/13719#discussion_r4077057752
##########
plugins/experimental/ja4_fingerprint/test_ja4.cc:
##########
@@ -251,6 +250,28 @@ TEST_CASE("JA4")
CHECK("ip" == call_JA4(TLS_summary).substr(8, 2));
}
+ SECTION("Given the first or the last byte of the ALPN value is not ASCII
alphanumeric, "
+ "when we create a JA4 fingerprint, "
+ "then indices [8,9] thereof should contain the hex representation of
those bytes.")
+ {
+ std::vector<std::pair<std::string, std::string>> values{
+ {std::string{"\xab"}, "ab"},
Review Comment:
Fixed in dcf52416e7. `get_first_ALPN` now validates the payload length
before reading the protocol-name length and bounds the slice, matching the
validation `jax_fingerprint` already performs, so a one-byte protocol name is
handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
