bneradt commented on code in PR #13719: URL: https://github.com/apache/trafficserver/pull/13719#discussion_r4077493876
########## plugins/experimental/ja4_fingerprint/ja4.cc: ########## @@ -114,15 +128,26 @@ convert_count_to_two_digit_string(std::size_t count) return result; } +// If either end of the value is not ASCII alphanumeric, the specification calls +// for the first and last characters of its hex representation instead, which +// are the high nibble of the first byte and the low nibble of the last byte. Review Comment: Adding the spec reference could be helpful here. Maybe: > See FoxIO JA4 spec, “ALPN Extension Value”: https://github.com/FoxIO-LLC/ja4/blob/main/technical_details/JA4.md#alpn-extension-value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
