maskit opened a new pull request, #13729: URL: https://github.com/apache/trafficserver/pull/13729
On BoringSSL builds, a plugin that parks the handshake in the client hello or cert hook is not waited for. The select certificate callback dropped the retry from the client hello step and mapped a cert hook pause to success, so the handshake carried on without the plugin. The callback has behaved this way since it was added in #8014. The `rate_limit_sni_expiry` and `tls_hooks_close_while_parked` tests from #13406 rely on the pause and fail on BoringSSL builds without this change. ## Changes - The select certificate callback returns a retry when the client hello hook or the cert hook pauses. - BoringSSL calls the callback again from the top once the hook reenables. After a cert hook pause, the client hello and servername steps are skipped rather than run twice. `TLSEventSupport::reached_cert_hooks()` tells the callback which case it is in. OpenSSL builds use a separate callback and are unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
