bneradt commented on code in PR #13695:
URL: https://github.com/apache/trafficserver/pull/13695#discussion_r4137874311
##########
src/proxy/http2/HTTP2.cc:
##########
@@ -45,6 +45,28 @@ struct Http2HeaderName {
static VersionConverter hvc;
+void
+establish_flow_control_policy(const char *name,
std::atomic<Http2FlowControlPolicy> &policy)
+{
+ auto update = [](const char *name, RecDataT type, RecData data, void
*cookie) -> int {
Review Comment:
1. Doesn't it rather refer to the passed in `name` parameter rather than the
outer `name` variable?
2. Doesn't compile huh? How did CI build this and compile fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
