bneradt commented on code in PR #13695:
URL: https://github.com/apache/trafficserver/pull/13695#discussion_r4157247571
##########
doc/admin-guide/files/records.yaml.en.rst:
##########
@@ -5261,12 +5261,19 @@ HTTP/2 Configuration
a way that shares the window equally among all concurrent streams.
=====
===========================================================================================
+ Reloading this setting applies the new policy only to connections
initialized
+ after the update. Existing connections retain the policy selected when they
+ were initialized, including for streams opened after the reload. Close and
+ reopen a connection to use the new policy.
+
.. ts:cv:: CONFIG proxy.config.http2.flow_control.policy_out INT 0
:reloadable:
Specifies the mechanism |TS| uses to maintian flow control via the HTTP/2
Review Comment:
Fixed the spelling in both the inbound and outbound policy descriptions in
ea459aa6aa. The documentation build passes.
##########
src/proxy/http2/HTTP2.cc:
##########
@@ -45,6 +45,28 @@ struct Http2HeaderName {
static VersionConverter hvc;
+void
+establish_flow_control_policy(const char *name,
std::atomic<Http2FlowControlPolicy> &policy)
+{
+ auto update = [](const char *name, RecDataT type, RecData data, void
*cookie) -> int {
+ ink_assert(type == RECD_INT);
+ RecInt value = data.rec_int;
+
+ if (value < 0 || value > 2) {
+ Error("Invalid value for %s: %" PRId64, name, value);
Review Comment:
Added an explicit <cinttypes> include in ea459aa6aa so PRId64 does not
depend on indirect includes. The build and http2_flow_control_reload AuTest
pass in asfats5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
