moonchen commented on code in PR #13747:
URL: https://github.com/apache/trafficserver/pull/13747#discussion_r4186739224


##########
src/records/unit_tests/test_ConfigReloadTask.cc:
##########
@@ -146,3 +146,24 @@ TEST_CASE("State to string conversion", 
"[config][reload][state]")
   
static_assert(ConfigReloadTask::state_to_string(ConfigReloadTask::State::SUCCESS)
 == "success");
   
static_assert(ConfigReloadTask::state_to_string(ConfigReloadTask::State::FAIL) 
== "fail");
 }
+
+TEST_CASE("ConfigReloadTask tree is freed with its owner", 
"[config][reload][lifetime]")

Review Comment:
   Done in fa70d2a75b. `test_ConfigReloadProgress` starts ET_TASK and checks 
that the checker releases its task through both exits: a confirmed terminal 
state and a timeout. It also includes the orphan-child case from #13757 in 
`test_ConfigReloadTask.cc`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to