Copilot commented on code in PR #13809:
URL: https://github.com/apache/trafficserver/pull/13809#discussion_r4252467839
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -1025,6 +1043,10 @@ ssl_callback_info(const SSL *ssl, int where, int ret)
}
if (where & SSL_CB_HANDSHAKE_DONE) {
// handshake is complete
+#if HAVE_SSL_CTX_SET_CLIENT_HELLO_CB
+ // The raw ClientHello has been recorded. Stop the per record message
callbacks.
+ SSL_set_msg_callback(const_cast<SSL *>(ssl), nullptr);
Review Comment:
ATS permits TLS 1.2 client renegotiation when
`proxy.config.ssl.allow_client_renegotiation` is enabled. Disabling this
callback after the initial handshake means a later ClientHello is not recorded,
while `_has_raw_extension_types` remains true; the renegotiation hook therefore
exposes the first ClientHello's extension list. Keep the message callback
active for connections on which renegotiation is allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
