JosiahWI commented on PR #13856:
URL: https://github.com/apache/trafficserver/pull/13856#issuecomment-6290396458

   @toxicteddy00077 Some existing gold tests appear to be impacted by this 
change. If they were testing for the wrong behavior, they will need to be 
updated, and that may be sufficient to cover the correctness of this change. 
The convert_ssl_multicert test is one of these.
   
   I haven't rerun all the gold test jobs, but here is the failure diff for 
convert_ssl_multicert:
   ```
             Reason: File differences
              Gold File : 
/home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/traffic_ctl/convert_ssl_multicert/gold/full.yaml
              Data File : 
/tmp/sandbox/worker-0/convert_ssl_multicert/_output/1-tr-Default/stream.stdout.txt
                ssl_multicert:
                  - ssl_cert_name: server.pem
                    dest_ip: "*"
                    ssl_key_name: server.key
                    ssl_ticket_enabled: 1
                    ssl_ticket_number: 3
                  - ssl_cert_name: ecdsa.pem,rsa.pem
                    dest_ip: 10.0.0.1:443
                    ssl_key_name: ecdsa.key,rsa.key
                    ssl_ca_name: ca.pem
                    ssl_ocsp_name: ocsp.der
                  - ssl_cert_name: encrypted.pem
              -     dest_ip: "*"
                    ssl_key_dialog: exec:/usr/bin/getpass foo
                  - dest_ip: 192.168.1.1
                    action: tunnel
                  - ssl_cert_name: wildcard.pem
              -     dest_ip: "*"
                    dest_fqdn: "*.example.com"
                    ssl_ticket_enabled: 0
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to