Copilot commented on code in PR #13737:
URL: https://github.com/apache/trafficserver/pull/13737#discussion_r4339023740
##########
doc/admin-guide/monitoring/statistics/core/network-io.en.rst:
##########
@@ -52,6 +52,23 @@ Network I/O
.. ts:stat:: global proxy.process.net.connections_currently_open integer
:type: counter
+ The number of open client and origin server connections, which
+ :ts:cv:`proxy.config.net.connections_throttle` limits.
Review Comment:
`proxy.process.net.connections_currently_open` is described here as 'the
number of open connections' and is updated via
`Metrics::Gauge::{increment,decrement}` in the codepaths shown in this PR, so
documenting it as `:type: counter` is inconsistent/misleading. Update the doc
to reflect its gauge semantics (or align the wording/type with the actual
metric type used by ATS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
