Copilot commented on code in PR #13737:
URL: https://github.com/apache/trafficserver/pull/13737#discussion_r4339023671
##########
src/iocore/net/UnixNetAccept.cc:
##########
@@ -77,6 +72,19 @@ handle_max_client_connections(IpEndpoint const &addr,
std::shared_ptr<Connection
return true;
}
+/// Count an accepted client connection, and whether it is from the client
exempt list.
+void
+count_client_connection(UnixNetVConnection *vc, bool exempt)
+{
+ Metrics::Gauge::increment(net_rsb.connections_currently_open);
+ vc->set_client_exempt(exempt);
+ if (exempt) {
+ Metrics::Counter::increment(net_rsb.per_client_connections_exempt_in);
+
Metrics::Gauge::increment(net_rsb.per_client_connections_exempt_currently_open);
+ Dbg(dbg_ctl_iocore_net_accepts, "Accepted a client connection from an
address in the exempt list.");
Review Comment:
The file defines `dbg_ctl_iocore_net_accept` but the new logging line uses
`dbg_ctl_iocore_net_accepts` (different symbol). If
`dbg_ctl_iocore_net_accepts` isn’t defined elsewhere, this is a compile error;
even if it is, it’s inconsistent within this TU. Use the same `DbgCtl`
identifier consistently (e.g., change the `Dbg(...)` call to use
`dbg_ctl_iocore_net_accept`, or rename the local `DbgCtl` to match the symbol
being used).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
