cmcfarlen commented on code in PR #13733: URL: https://github.com/apache/trafficserver/pull/13733#discussion_r4353364167
########## src/traffic_server/traffic_server.cc: ########## @@ -1971,6 +1973,22 @@ configure_io_uring() } #endif +// Runs when an exception escapes on any thread. The terminate handler runs Review Comment: Non-blocking nit: this holds for an exception that has no handler at all, but not one that escapes through a `noexcept` frame. In that case GCC and Clang unwind down to the `noexcept` frame before calling `std::terminate`, so the frames between the throw and that frame are gone from the core. A short caveat would keep the comment accurate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
