bryancall commented on code in PR #13733: URL: https://github.com/apache/trafficserver/pull/13733#discussion_r4379606046
########## src/tscore/unit_tests/test_Demangle.cc: ########## @@ -0,0 +1,80 @@ +/** @file + + Tests for the exception description helpers. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "tscore/Demangle.h" + +#include <catch2/catch_test_macros.hpp> + +#include <stdexcept> +#include <string> + +namespace +{ +struct NotAnException { +}; + +std::string +describe_thrown(auto const &thrown) Review Comment: ATS requires C++20: the top-level `CMakeLists.txt` sets `CMAKE_CXX_STANDARD` to 20 with `CMAKE_CXX_STANDARD_REQUIRED ON`, so the abbreviated template and `std::string::ends_with` build everywhere the tests do. ########## src/tscore/unit_tests/test_Demangle.cc: ########## @@ -0,0 +1,80 @@ +/** @file + + Tests for the exception description helpers. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "tscore/Demangle.h" + +#include <catch2/catch_test_macros.hpp> + +#include <stdexcept> +#include <string> + +namespace +{ +struct NotAnException { +}; + +std::string +describe_thrown(auto const &thrown) +{ + try { + throw thrown; + } catch (...) { + return ts::describe_current_exception(); + } +} +} // namespace + +TEST_CASE("demangle", "[libts][Demangle]") +{ + CHECK(ts::demangle(typeid(int)) == "int"); + CHECK(ts::demangle(typeid(std::runtime_error)).find("runtime_error") != std::string::npos); + CHECK(ts::demangle(typeid(NotAnException)).find("NotAnException") != std::string::npos); +} + +TEST_CASE("describe_current_exception", "[libts][Demangle]") +{ + SECTION("a std::exception reports its type and message") + { + auto const text = describe_thrown(std::runtime_error{"boom"}); + + CHECK(text.find("runtime_error") != std::string::npos); + CHECK(text.ends_with(": boom")); Review Comment: ATS requires C++20: the top-level `CMakeLists.txt` sets `CMAKE_CXX_STANDARD` to 20 with `CMAKE_CXX_STANDARD_REQUIRED ON`, so the abbreviated template and `std::string::ends_with` build everywhere the tests do. ########## src/traffic_server/traffic_server.cc: ########## @@ -1971,6 +1973,24 @@ configure_io_uring() } #endif +// Runs when an exception escapes on any thread. The terminate handler runs +// before the stack unwinds, so aborting from here keeps the throwing frame in +// the core. The one exception is a throw that leaves a noexcept function: the +// runtime unwinds to that function's frame before it calls terminate, so the +// core loses the frames between the throw and it. Catching in main() instead +// would unwind those frames first and would miss other threads entirely. main() +// installs this before init_system() registers the crash handler, and before +// crash_logger_init() starts the crash logger. A throw in that window still +// aborts and dumps a core, but writes no crash log. +[[noreturn]] void +abort_on_uncaught_exception() +{ + if (std::current_exception()) { + ink_abort("traffic_server: terminating on an unhandled %s", ts::describe_current_exception().c_str()); + } + ink_abort("traffic_server: terminate called without an active exception"); Review Comment: `ink_abort()` is declared `TS_NORETURN` in `include/tscore/ink_error.h`, so the compiler knows the first call never returns and there is no fallthrough to the second one. ########## src/tscore/Demangle.cc: ########## @@ -0,0 +1,79 @@ +/** @file + + Readable C++ type names. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "tscore/Demangle.h" + +#include <cstdlib> +#include <cxxabi.h> Review Comment: ATS only builds with GCC and Clang on Itanium C++ ABI platforms (Linux, macOS, FreeBSD), where `<cxxabi.h>` and both functions are always present. `src/traffic_crashlog/backtrace.cc` already includes `<cxxabi.h>` unguarded, so a guard here would cover a build that cannot happen. ########## src/tscore/Demangle.cc: ########## @@ -0,0 +1,79 @@ +/** @file + + Readable C++ type names. + + @section license License + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + */ + +#include "tscore/Demangle.h" + +#include <cstdlib> +#include <cxxabi.h> +#include <exception> +#include <memory> + +namespace +{ +struct FreeDeleter { + void + operator()(char *p) const noexcept + { + std::free(p); + } +}; +} // namespace + +namespace ts +{ +std::string +demangle(std::type_info const &type) noexcept +{ + try { + int status = 0; + std::unique_ptr<char, FreeDeleter> name{abi::__cxa_demangle(type.name(), nullptr, nullptr, &status)}; Review Comment: ATS only builds with GCC and Clang on Itanium C++ ABI platforms (Linux, macOS, FreeBSD), where `<cxxabi.h>` and both functions are always present. `src/traffic_crashlog/backtrace.cc` already includes `<cxxabi.h>` unguarded, so a guard here would cover a build that cannot happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
