brbzull0 commented on PR #13636: URL: https://github.com/apache/trafficserver/pull/13636#issuecomment-6361469636
@maskit Correction first: the description and my September comment put both of these in #13655, and neither landed there. They are in this PR now. I merged master into the branch first (2fae388ccc), which brings in the `||` guards from #13655. - d18b0e6f59 adds `arena.str_free(*name)` on the value-error return in `_read_insert_without_name_ref()`, as you suggested. - 1384806add adds the test. To let it see the arena, `QPACK.h` gains `friend struct QPACKTestAccess;`, test-only. The new encoder stream case hands Insert Without Name Ref instructions to `_on_encoder_stream_read_ready()`, checks the arena gets back every name and value, and resolves the inserted entries through a header block. A second section checks that a value that fails to decode gives the name back and fails the decoder. The literal decode case uses the same probe now. Removing or reordering any of the releases this PR adds or reorders in `QPACK.cc` fails one of them. The case calls the handler directly because a stream written from the test thread never reaches QPACK: the read event is scheduled on a thread that does not dispatch events. Description updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
