jplevyak commented on code in PR #13893:
URL: https://github.com/apache/trafficserver/pull/13893#discussion_r4366043639


##########
src/iocore/cache/unit_tests/test_RamCacheCLFUS.cc:
##########
@@ -398,3 +428,183 @@ TEST_CASE("CLFUS value metric is a floating-point 
density", "[cache][ramcache][c
   static_assert(v_hot > v_one, "CLFUS value metric does not increase with 
hits");
   static_assert(v_small > v_large, "CLFUS value metric does not decrease with 
size");
 }
+
+namespace
+{
+
+CryptoHash
+make_key(uint64_t id)
+{
+  CryptoHash key;
+  key.u64[0] = 0xc0ffee00 + id;
+  key.u64[1] = 0xdeadbeef + id;
+  key.u32[3] = static_cast<uint32_t>(0x12345678 + id);

Review Comment:
   It now writes only through u32[].



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to