jplevyak commented on PR #13893: URL: https://github.com/apache/trafficserver/pull/13893#issuecomment-6380383235
Addressed both "previously missed" items from the last review in 833424347: - **Spared-victim decay:** the test now asserts `hits == 7` (16 → 8 when spared, 8 → 7 when requeued), so it fails if the halving is removed. - **Seen-filter second sighting:** new test `CLFUS seen filter admits a filtered key on its second sighting`. With the filter active and the cache full, a key rejected on first sight becomes resident on its second sighting when the victims are worth less, and goes to history (residents kept) when they're worth more. I checked each test by removing the code it covers and confirming it fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
