bneradt commented on PR #481: URL: https://github.com/apache/trafficserver-ci/pull/481#issuecomment-6388044626
Answers to the reviewer questions in the description: 1. **Cron vs. systemd timer:** systemd timer. Commit 3 adds `github-mirror-maintenance.service`/`.timer`, installed by `install-controller.sh` like the fallback timer, so a controller rebuild reproduces it, output goes to journald (the cron log had no logrotate), and the run gets a `TimeoutStartSec`. The installer deletes the old cron file. The controller needs `install-controller.sh` re-run after merge. 2. **Origin of the 2026-10-14 tuning:** it was applied directly on the controller while fixing the controller OOM on 2026-10-14 (my session, with Claude), and never committed. Upstream as-is. The numbers are consistent: 16 request workers × ~100 MiB per `git-upload-pack` fits under `mem_limit: 2g`, and the event MPM values are valid (`MaxSpareThreads` 16 ≥ `MinSpareThreads` + `ThreadsPerChild`). 3. **`pack.threads=2`/`128m` in maintenance vs `1`/`64m` for serving:** intentional. The serving limits apply to each of up to 16 concurrent upload-packs inside the 2 GiB container. The repack is one off-peak run in the fallback container, which has no memory limit and doesn't see httpd's system git config, and a larger delta window shrinks the single pack every clone then reuses. Commit 3 adds a comment saying this. 4. **git-daemon on `0.0.0.0:9418`:** it should be loopback only (`--listen=127.0.0.1` in `config/git-daemon.default`), since Jenkins uses HTTPS through ATS and `git://` is only a diagnostic path. That also means updating the README's external `git ls-remote git://ci.trafficserver.apache.org/...` example. It changes behavior, so I'll do it in a follow-up rather than this sync PR. 5. **Stale header in the live webhook env file:** agreed; fix it on the controller the next time that file is edited. No repo change needed. One more thing to watch: `maintain-mirrors.sh` holds each repo's lock for the whole repack, and `update-mirror.sh` waits only `LOCK_WAIT=300`. If a `trafficserver.git` repack takes more than 5 minutes, webhook updates around 09:30 UTC fail and are picked up by the next 5-minute fallback run. We should check the repack duration in the journal after the first timer run and raise `LOCK_WAIT` if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
