bneradt commented on PR #13892: URL: https://github.com/apache/trafficserver/pull/13892#issuecomment-6392043378
Addressed the review in ce401e2c5e, folded into the existing prerequisite/migration commits: - HTTP/2 destroy caches both endpoints before closing the socket. A session hook regression compares valid numeric addresses and nonzero ports at SSN_START and SSN_CLOSE. It failed against the old installed binary with "Session address has an invalid family" and passed with the fix. The prerequisite commit and PR description explain the production change. - Cookie-remap paths/queries and Lua response headers/bodies now have explicit verification rules. Repeating the NOTEXISTS → EXISTS production mutation failed with the expected /cookieexists versus /cookiedoesntexist mismatch. A deliberately wrong Lua body expectation also failed; both mutations were reverted. - Audited the other direct replays for inert URL/header/literal-body values, corrected 17 additional manifests, and added a framework guard. Two cookie collapse cases verify the complete received request line because Proxy Verifier misparses :// inside their query strings. The prefetch case verifies origin request lines and its prefetch header in the log because prefetch copies the original UUID. - Restored the missing global header-rewrite 303 test. The audit also restored the HTTP/2 priority test’s original full-body SHA256 assertion using a native curl test. ESI’s original gold checked status/cache-control, which remain covered. - Corrected all five TLSv1_3 record names and added actual TLS1.2 negotiation/dump checks. Restored full TLS-hook gold and multiplicity checks, manager.log rotation checks, the original SNI wildcard patterns, and the cache-control request sequence including only-if-cached against the previously fetched uncacheable URL. - Corrected the unsupported SSL-secret hook comment; removed unsupported txn_box/engine/CMake/dead-runner/Cripts leftovers; updated the two in-repository CI runners and distribution inventory. Validation: final related suite 79 passed, 1 skipped (-n 4); the restored priority test and expanded cache-control replay then both passed. Framework: 119 passed. Build/install, make -j8 format, Sphinx docs, and distribution packaging passed. RAT on the staged source archive reported 0 unknown licenses. No assertions were replaced with skips or expected failures. Thank you for the detailed independent checks and mutation tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
