bneradt commented on code in PR #13892: URL: https://github.com/apache/trafficserver/pull/13892#discussion_r4383319883
########## tests/Makefile.am: ########## @@ -30,17 +30,28 @@ AM_LDFLAGS += $(TS_PLUGIN_LD_FLAGS) # generation of so objects for these test files. AM_LDFLAGS += -rpath $(abs_builddir) -include gold_tests/bigobj/Makefile.inc -include gold_tests/at_headers/plugins/Makefile.inc -include gold_tests/continuations/plugins/Makefile.inc -include gold_tests/chunked_encoding/Makefile.inc -include gold_tests/pluginTest/tsapi/Makefile.inc -include gold_tests/timeout/Makefile.inc -include gold_tests/tls/Makefile.inc +include uranium_tests/bigobj/Makefile.inc +include uranium_tests/at_headers/plugins/Makefile.inc +include uranium_tests/continuations/plugins/Makefile.inc +include uranium_tests/chunked_encoding/Makefile.inc +include uranium_tests/pluginTest/tsapi/Makefile.inc +include uranium_tests/timeout/Makefile.inc +include uranium_tests/tls/Makefile.inc include tools/plugins/Makefile.inc TESTS = $(check_PROGRAMS) +.PHONY: urtest urtest-replay +urtest: + bash ./urtest.sh $(URTEST_OPTIONS) + +urtest-replay: + bash ./urtest.sh -m replay $(URTEST_OPTIONS) + +EXTRA_DIST = urtest.sh urtest.sh.in pyproject.toml uv.lock Review Comment: Thanks, confirmed. Fixed in d1ad18e609 (folded into the existing in-source-build commit). I used the suggested dist-hook: it overwrites the distribution copy with $(srcdir)/urtest.sh. This preserves the existing out-of-tree build/tests/urtest.sh interface used by CI while ensuring the tarball contains the portable launcher. Added a regression that starts with a stale configured wrapper, runs the actual Makefile.am distribution hook, compares the result byte-for-byte with the source launcher, and verifies argument forwarding to urtest-configured.sh. Validation: build and make -j8 format passed; all 121 framework tests passed. The regenerated tests distribution target passed; I archived and unpacked its output, verified the launcher bytes, overlaid those distributed tests onto a clean source export, configured in-tree, and successfully ran make -C tests urtest URTEST_OPTIONS="--help". Full top-level make dist is separately blocked by pre-existing missing EXTRA_DIST entries (CHANGES and LAYOUT); this change does not modify those unrelated entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
