bneradt commented on PR #13928: URL: https://github.com/apache/trafficserver/pull/13928#issuecomment-6481309185
Thanks for the careful review. All of it is addressed in the latest push. **Diag checks relaxed per case, matching the originals** - `regex_remap`: keeps the original allow-list. `ATS` gains `allow_errors(expression)`, so only `ERROR:` lines matching an allowed expression pass, and any other error still fails teardown. It has a framework self-test. - `esi`: only the `max-doc-100` variant relaxes the checks. - `traffic_dump_ip_filter`: only ts3 relaxes them. - `http2_incomplete_header_timeout`: only the case that expects the timeout relaxes them. - `basic_conf_remap`: only the cases that expect a diagnostic relax them: the two startup failures and the mixed-records warning. The plain success cases keep the default checks. **Exit code 75 under `-m`** Fixed. The doc now says 75 means the `-T` timeout expired, and that `-m` attaches to a reload already in progress. **Smaller items** - `test_config_reload_full_smoke.py` now asserts the reload status is `success`. - The "Test plugins" block in `config-reload-framework.en.rst` now points at `tests/uranium_tests/jsonrpc/plugins/` and `test_config_reload_plugin_api.py`. - The `ATS.close()` docstring now says `expect_start_failure()` skips every diagnostic check, including the missing-diags.log assert. `uranium-api.en.rst` describes the checks and `allow_errors()`. - Root runs: the multicert tests now hand the generated keys to the ATS user through a new `ATS.chown_for_ats()`, instead of skipping. All 10 pass when run as root. The `test_runroot` skip stays, because root can write a 0400 file, so that permission failure can't happen as root. - `test_slice_stale_generation.py` again requires `blk_range` and `etag_got` on the same Mismatch line. - `test_config_reload_failures.py` restores the bad-cert reload and makes its checks real, since the original's validators always passed. It writes the live `ssl_multicert.yaml` (`write_config_file()` only stages a file for start, which is why the old helper looked unused). It then requires the root task and the `ssl_multicert.yaml` task to be `fail`, and the following good reload to succeed. Only the two deliberate SSL errors are allowed in diags.log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
