HiLleywyn commented on PR #13913: URL: https://github.com/apache/trafficserver/pull/13913#issuecomment-6538015290
Following up on my earlier test comment: Bryan’s review found a path my scoped tests missed. I traced it and agree it’s blocking. Keeping `must-revalidate` or `proxy-revalidate` while dropping the malformed `max-age` can turn a malformed 302 into a positively cacheable response with heuristic freshness. The later-token cases, such as `max-age=600; private`, are also still lost. I’m withdrawing my earlier “no blockers” conclusion for this head. The tests I reported did pass, but their coverage was incomplete. +1 to revising this and adding the 302 and later-token regressions before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
