bneradt commented on PR #13913: URL: https://github.com/apache/trafficserver/pull/13913#issuecomment-6636311866
@bryancall thanks for the second pass. Updated in 80d93f46a0, rebased on master. **Restriction after an unknown first token:** when an element starts with a directive ATS doesn't know, its `=value` is now skipped the same way as on the known path, and whatever is left is scanned for no-cache, no-store and private. `stale-while-revalidate=60; private`, `immutable; private`, `x-ext; no-store`, Copilot's `x-custom; private, max-age=600`, `x-ext="a, b"; private` and `; private` all keep their restriction now. A well-formed `x-custom=private` is still ignored. All six new restrictive unit rows fail without the MIME.cc change and pass with it. The new `stale-while-revalidate=60; private` replay pair also fails without it: user B gets user A's body as `hit-fresh`. With the change, both requests go to the origin. The other Cache-Control urtests pass too. **"Only cache less" sentence:** I dropped it from the description and commit message. Both now say that a kept malformed no-cache turns off the `Pragma: no-cache` storage check. So `max-age=600; no-cache` with Pragma and Expires is stored now, but every later request is revalidated with the origin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
