traeak commented on code in PR #12593:
URL: https://github.com/apache/trafficserver/pull/12593#discussion_r4447401030
##########
src/proxy/http/remap/PluginFactory.cc:
##########
@@ -216,8 +217,18 @@ PluginFactory::getRemapPlugin(const fs::path &configPath,
int argc, char **argv,
plugin = new RemapPluginInfo(configPath, effectivePath, runtimePath);
if (nullptr != plugin) {
- if (plugin->load(error, _compilerPath)) {
- if (plugin->init(error)) {
+ bool loaded = false;
+ bool initialized = false;
+ {
+ // TSRemapInit is plugin-global: hide the loading rule from the
strategy APIs.
+ UrlMappingInstanceScope const no_rule{nullptr};
Review Comment:
Resolved transitively: ts::proxy → ts::http → ts::http_remap (static link
deps propagate). The test links and passes; CI passed on all platforms with
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
