traeak commented on code in PR #12593:
URL: https://github.com/apache/trafficserver/pull/12593#discussion_r4447391961
##########
src/proxy/http/remap/unit-tests/CMakeLists.txt:
##########
@@ -324,3 +324,25 @@ target_link_libraries(
)
add_catch2_test(NAME test_RemapRulesYaml COMMAND
$<TARGET_FILE:test_RemapRulesYaml>)
+
+### test_StrategyApi
########################################################################
+add_executable(test_StrategyApi test_StrategyApi.cc)
+
+target_compile_definitions(test_StrategyApi PRIVATE
TS_SRC_DIR=\"${CMAKE_CURRENT_SOURCE_DIR}\")
+
+# tsapi_objects rather than the shared tsapi, which fails to load on macOS
(ET_UDP).
+target_link_libraries(
+ test_StrategyApi
+ PRIVATE Catch2::Catch2WithMain
+ tsapi_objects
+ ts::http
Review Comment:
Not true. test_PluginFactory links ts::proxy, which publicly links ts::http,
which privately links ts::http_remap. For static libraries, CMake still passes
a private dependency through to the final link, so UrlMapping.cc ends up in the
binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
