jplevyak commented on PR #13893: URL: https://github.com/apache/trafficserver/pull/13893#issuecomment-6563628924
@bryancall Thanks for the thorough review. Addressed in c1e2483a8: - **Wall clock steps:** `_decay_epochs()` resets `_last_decay_time` when `elapsed < 0`. Forward steps are left as is, since aging everything at once is harmless. - **seen_match before saturation:** not intended. `seen_match` is now set only when `_history >= _objects`, so the unsaturated path matches master. New test covers a tag collision with unsaturated history. - **hits = 2:** commented, and the history test now checks it. That test already exercises it: `e2` survives the `_tick()` from `key3`'s put, and with `hits = 1` it is freed. - **Comments:** the size-curve comment now states it is `2(h+1)/(size+4608)`, a fixed ~4.5 KiB charge (1K:64K ~12.5x vs ~51x). Fixed the "64x" test comment and the `RamCacheCLFUSTestAccess` comment, and removed the restated ones. - **Null deref:** `REQUIRE` on both pointers. - **hits++ wrap:** left as is. A wrap needs ~4B touches in one epoch and only makes one entry look cold for one epoch. Each new check fails with its fix reverted. All 78 cache tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
