Please review this branch:
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commits/rails-3.1-devise
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commits/rails-3.1-devise>
It is rebased with mainline/master. All commits can be merged to master
except the last one, which is not completed yet.
Currently, here are the missing bits:
- Cookies are not marked as "secure" yet;
- OpenID authentication is the only failing test and is not implemented
yet. I still need to investigate how OpenID works in Gitorious. But this
needs a rework for sure in the user interface with buttons pointing out
to Google, Yahoo, etc besides the OpenID URL edit for easing its usage.
Maybe we could do that after migrating Gitorious to Rails 3;
- The session expire check was disabled for the SSL tests to pass. It
would be great to add some test for verifying this cache behavior. I
didn't verify yet if this check is necessary for Warden/Devise;
- There is no test regarding the Varnish cache server and I don't know
what to expect from it;
Please review the current status and guide me with suggestions for
achieving the missing parts and detect bugs not covered by tests as well
as improvement suggestions to the patch.
If someone wants to help integrate OpenID to Gitorious with Devise, one
can start from here:
https://gitorious.org/~rosenfeld/gitorious/rosenfeld-gitorious/commits/rails-3.1-devise-openid-temp
<https://gitorious.org/%7Erosenfeld/gitorious/rosenfeld-gitorious/commits/rails-3.1-devise-openid-temp>
There is nothing yet, except from new dependencies set.
Here is an example application using Devise and the
devise_openid_authenticable gem:
https://github.com/rosenfeld/devise_openid_example
It is a fork of the repository below with updated config/environment.rb
to reflect the Gitorious situation:
https://github.com/nbudin/devise_openid_example
Best regards,
Rodrigo.
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
