Em 23-06-2011 04:55, Christian Johansen escreveu:
Hi Rodrigo,
Good work!
On Fri, Jun 17, 2011 at 03:17, Rodrigo Rosenfeld Rosas
<[email protected] <mailto:[email protected]>> wrote:
A quick update: after setting up Nginx, enabling SSL and
development mode, I could verify that my commit in Devise's pull
request did work as I expected.
I've just pushed a commit to rails-3.1-devise for setting the
cookie as secure when use_ssl is set.
I noticed your patch has been merged. Does this mean we can switch the
Gemfile back to some official version?
Great to know, I didn't know that (Github didn't notify me). I've pushed
another commit to reflect that merge. I'll merge all these commits
related to Devise in the end for helping you to see the progress in
small steps...
Hi there! I know I've disappeared for a while, but don't worry:
I'm alive! :) It is just that I was upgraded to 3.0 on monday so
I'm not as fast as I was in my twenties ;)
Congrats :)
I'll try to use the version from my repository as soon as I get
some time for getting rid of the secure cookie limitation. Then,
the only missing part will be OpenID support if I remember
correctly. I'm still waiting for the tests on session and caching.
Sorry about that, will get them in today or tomorrow.
I would like if you could help me merging all commits before the
conversion to Devise into master. All of them are not Devise
related but may result in unnecessary work when rebasing my
branch... :(
So, cherry-pick commits up to some point in the devise branch? Maybe
you can be a little more specific as to which commits to pick? I've
updated the official rails-3.1 branch with your latest work at least.
I'm saying that those commits are not specific to Rails 3 and could be
already merged into master. Here is the list of commits I'm talking about:
Fix Gemfile.lock
Duplicated (redundant) oauth dependency in Gemfile
Removes unused partial view
Use 2 spaces instead of tabs in sessions/new.html.erb
Remove vendored state-machine plugin as it was already included
in Gemfile
refactoring: replace vendored hodel_3000_compliant_logger with
its gem
make "reserved?" implementation clearer and faster in some cases
Fix typo
Only caches url reservations after Rails initialization completes
You don't need to cherry-pick if you agree with all of them. Just merge
with "Only caches..." for instance... I've just rebased to master.
How about you? How are you doing? (yes, being 30 years old also
mean I get more social, I guess - I don't know, I'm still getting
used to it ;) )
Hehe. We've been working on HTTP push, which is close to ready. It's
going to rock for sure :)
Great to know, although I don't intend to use it myself :)
Big hugs, Rodrigo
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
