Hi Arthur,
So useful report, much appreciation, thx!
I have looked into the error and found out that member_dns method on
LdapGroup didn't properly handle nil value. I have made a fix for that.
The fix is in the master, please pull and let me know if all is cool on
the LDAP front.
Cheers!
Marcin
On 13/12/13 16:28, Arthur L. wrote:
Hi Dan,
I have good news. I've been working on LDAP authorization last couple of days
and I have managed to spot and fix the bugs you've mentioned, plus few other
small annoyances.
Here's the summary:
* improved ldap-wizard/wizard.rb gem dependecy loading (moved sinatra-contrib out of
"development" to its own bundler group) and made it bind on 0.0.0.0 by default,
* made the errors related to bind_user setting more explicit,
* missing partial issues is fixed,
* profile page is also fixed
* few other smaller improvements.
Could you please checkout the latest master, re-enable ldap authorization and check if the issues
are gone for you? Both "Teams" and "Profile" pages should be functional with
LDAP now.
Oh, and many thanks Dan for you detailed report about LDAP state. You helped
Gitorious a lot!
Hi,
I have installed 3.0 from the latest master (upgraded form 2.3). I'm using LDAP
authentication and it seems to work fine, but when trying to create a new team,
it fails with this LDAP related error:
ActionView::Template::Error (undefined method `join' for nil:NilClass):
32: </div>
33: </div>
34: <% if group.is_a?(LdapGroup) %>
35: <%= form.input(:ldap_group_names, :as => :text, :hint => "Enter LDAP
group RDNs (Relative DN), one per line "+
36: "<strong>Note:</strong> entries should be relative to the LDAP base
DN") %>
37: <% end %>
app/models/ldap_group.rb:79:in `ldap_group_names'
app/views/groups/_form.html.erb:35:in
`_app_views_groups__form_html_erb___735330224564984729_71161820'
app/views/groups/new.html.erb:34:in `block in
_app_views_groups_new_html_erb__1801841951155751091_74076280'
app/views/groups/new.html.erb:29:in
`_app_views_groups_new_html_erb__1801841951155751091_74076280'
app/controllers/groups_controller.rb:62:in `new'
app/middlewares/dolt_cache_middleware.rb:24:in `call'
app/middlewares/dolt_auth_middleware.rb:26:in `call'
Could this be a bug or is it just a configuration issue or messed up migration
from 2.3?
--
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
---
You received this message because you are subscribed to the Google Groups "Gitorious" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
