Hi,
On Aug 20, 2009, at 11:53 AM, Johannes Gilger wrote:
Hi Gerd,
thanks for your patches. I have rebased them onto my latest
bugfixes-change (merging XIBs is always fun...) and they appear to
work
fine. Code-wise there isn't much to discuss, still I have a few
questions:
2. About the SHA: There have been at least three patches I've seen
which
implement SHA-1 in the table, which is a clear sign that people really
want it. Whether we should hardcode the length to 7 chars or using
some
other mechanism is another question, but since the implementation of
your method can always be changed later on I'd say we just go with it
for now and wait for kind of feature-request for this thing come in.
I don't mind adding this column, but I think it should be hidden by
default. I added all the infrastructure that's necessary to show/hide
columns, so I think it will work by just setting it hidden by default
in XCode.
As for the length of the SHA, I think we should just use the full sha
in the column. If you want less characters, you can just narrow the
column to what you want :)
(As for GitX 0.7, I think we should just release something soon,
rather than wait on the file watcher stuff. There's one bug in the
current HEAD where doing something in the commit view actually deletes
thefile from the index. I haven't been able to figure out how that
works exactyl, but it should definitely be fixed before we ship 0.7)
Thanks,
Pieter
