On Aug 20, 4:53 am, Johannes Gilger <[email protected]> wrote:
> Hi Gerd,
>
> thanks for your patches. I have rebased them onto my latest
> bugfixes-change (merging XIBs is always fun...) and they appear to work
> fine. Code-wise there isn't much to discuss, still I have a few
> questions:
>
> 1. What is the first patch good for? What are external build products?
> I'm sorry for being so ignorant, but I barely use XCode at all, most of
> the time I just run the rake task and it works ;)
>
Sorry for the late response, somehow with signing up etc I lost
continuity on this group.
Some scripts expected the build to happen in a "build" directory
within the project directory. I have my Xcode preferences set to use a
different directory instead (one that is not backed up, excluded from
timemachine and spotlight etc). With a setting like that some of the
build scripts were failing. BTW I think there was a similar problem
for the "Release" build that my patches did not fix yet. I am away
from my machine, but when back I'll check and submit and addendum.
> 2. About the SHA: There have been at least three patches I've seen which
> implement SHA-1 in the table, which is a clear sign that people really
> want it. Whether we should hardcode the length to 7 chars or using some
> other mechanism is another question, but since the implementation of
> your method can always be changed later on I'd say we just go with it
> for now and wait for kind of feature-request for this thing come in.
>
Actually I did not notice until later that the search field can search
for SHAs, which pretty much took care of my need to have a SHA column
in the first place. I did add however another search option (which I
made the default) that searches Subject, Author and SHA. I find that
much more useful, and if I really just want to search for one of the
fields I can use the dropdown. If anybody else likes this I gladly
provide a patch for this.
Thanks
Gerd
