On Sat, Mar 27, 2010 at 11:55 PM, <[email protected]> wrote:
> From: Nathan Kinsinger <[email protected]>
>
> This will simplify methods that execute git commands that can take a ref or
> an SHA.
>
> Add some string constants so there is only one place for the type strings.
Ok, makes sense.
> -...@interface PBGitCommit : NSObject {
> +
> +extern NSString * const kGitXCommitType;
> +
> +
You add a committype here, and branch,tag,remote types in a next
commit. I think those are better suited in the PBGitRefish header?
> extern NSString * const kGitXTagRefPrefix;
> extern NSString * const kGitXBranchRefPrefix;
> extern NSString * const kGitXRemoteRefPrefix;
I meant these
> +- (NSString *)shortName
> +{
> + if ([self type])
> + return [ref substringFromIndex:[[self type] length] + 7];
> + return ref;
> +}
While you're at it, you might want to make this more solid, or at
least add a comment that the 7 is from '/refs/' and another '/' after
the type
Otherwise this looks like a smart change
To unsubscribe from this group, send email to gitx+unsubscribegooglegroups.com
or reply to this email with the words "REMOVE ME" as the subject.
