On Sep 13, 2010, at 3:15 AM, Johannes Gilger wrote: > Hi Nathan, > > I just checked your branch and the few small bugs of the last preview > you sent me seem to be gone. > > On 12/09/10 21:19, Nathan Kinsinger wrote: >> There are two main features. The first is an improved search >> interface. > I checked, and git does not offer regexes for path-limiting, which is > why one has to specify the full path to a file. So, no error on our > side. In the future we *might* think about expanding 'foo*' based on the > current worktree, much like you would when using a shell.
That is a very good idea. >> The second is more commands for the gitx command line tool. > The only thing still bugging me is that the GitX.app starts in the > background when invoked using 'gitx'. I don't know if this is a bug or a > feature and I don't know immediately where to look for it. It appears that I forgot to have the app activate when setting up a search. But the other commands should bring it to the front now (they didn't before by design for unknown reasons). I'll look into it. >> Let me know what you think and of course if you find any bugs. > So far I haven't found any bugs. I have rebased my bugfixes-branch based > on your work, it can be found at http://github.com/heipei/gitx > > A short log: > > Johannes Gilger (6): > PBGitCommit: Localized timestamps in "Date"-column > Commit-view: No 'Discard changes' for new files > History: Correctly wrap lots of tags > History-View: Clear list of files on showDiff > Diff-View: Honor whitespace preference > History: Show author/committer according to .mailmap > > Sebastian Staudt (1): > Commit-View: Option to commit without hooks Sebastian sent me a pull request which I commented on: http://github.com/brotherbard/gitx/pull/45 > These are a small patches and they can all be cherry-picked > individually, feel free to do so. Sebastian's patch is clearly a > feature, but I didn't feel the need to open a separate branch. Please > try to accept/reject patches from other people as directly as possible, > without a lot of back-and-forth. I've seen a lot of patches (including > mine) go nowhere because of endless discussion about programming style. > The easiest solution would be to just fix some minor quirks yourself and > then just append the patch (keeping the original author, I can't stress > this enough). For example, I changed the wording in Sebastian's patch > from 'Don't verify' to 'Don't run hooks' without consulting with him. I do try to at least look at other people's work. But I only have small bits of time here and there and I seem to lose track in between. That's why I think Github's pull request interface will be useful, keeps it in front of me. > A few notes if we do plan to release this: > - For now we should probably stick with the current GitX-homepage and > appcast feed, and have Pieter sign the 0.8 release, lest we get stuck > by all the technicalities surrounding a move to another page/stream. > - I worked my way through all the issues on lighthouse which were 'new'. > Now all the tickets have either been closed or replied to, and in most > cases assigned to the 0.8 milestone. Most of these assigned tickets > can be closed as soon as we release 0.8, and I always left a comment > which says so. > - The homepage/documentation can easily be updated after the release, so > we don't need to do this in advance. Most people will probably just > use autoupdate and never look at the homepage anyway. Sounds good. --Nathan http://brotherbard.com/
