#5408: ghc-7.2.1 build failed for PowerPC
----------------------------------+-----------------------------------------
  Reporter:  maeder               |          Owner:         
      Type:  bug                  |         Status:  patch  
  Priority:  normal               |      Milestone:         
 Component:  Compiler             |        Version:  7.2.1  
Resolution:                       |       Keywords:         
  Testcase:                       |      Blockedby:         
Difficulty:                       |             Os:  MacOS X
  Blocking:                       |   Architecture:  powerpc
   Failure:  Building GHC failed  |  
----------------------------------+-----------------------------------------

Comment(by simonmar):

 Thanks for the patch.  This hunk doesn't look right to me:

 {{{
 +ifeq "$(UseLibFFIForAdjustors)" "YES"
 +# When we use libffi, foreign import wrappers will #include "ffi.h" so
 +# we must tell the C preprocessor where it is.
 +SRC_HC_OPTS += -Irts/dist/build
 +SRC_CC_OPTS += -Irts/dist/build
 +endif
 +
 }}}

 (I couldn't add a comment in github, not sure why)

 We should be finding `ffi.h` in the same way that we find `Rts.h`,
 whatever that is.  If we have to do something magic in the build system to
 find `ffi.h`, won't that break when we install GHC?

 Modifying `SRC_HC_OPTS` in the build system is usually not the right thing
 to do - it is for `mk/build.mk` to set, with a default in `mk/config.mk`.
 You'll notice that no other `.mk` file in the build system sets
 `SRC_HC_OPTS` or `SRC_CC_OPTS`.

-- 
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/5408#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Reply via email to