#5408: ghc-7.2.1 build failed for PowerPC
----------------------------------+-----------------------------------------
Reporter: maeder | Owner:
Type: bug | Status: patch
Priority: normal | Milestone:
Component: Compiler | Version: 7.2.1
Resolution: | Keywords:
Testcase: | Blockedby:
Difficulty: | Os: MacOS X
Blocking: | Architecture: powerpc
Failure: Building GHC failed |
----------------------------------+-----------------------------------------
Comment(by PHO):
Thank you for reviewing my patches.
Replying to [comment:8 simonmar]:
> We should be finding `ffi.h` in the same way that we find `Rts.h`,
whatever that is.
I agree with you, but unlike {{{Rts.h}}}, libffi headers {{{ffi.h}}} and
{{{ffitarget.h}}} are dynamically generated by
{{{libffi/build/configure}}} so the correct fix would be to treat them in
a similar way as we treat {{{ghcautoconf.h}}} and {{{ghcplatform.h}}}.
That is, let {{{libffi/ghc.mk}}} copy them directly into {{{includes}}},
not into {{{rts/dist/build}}}. Do you think this is appropriate? If so,
I'll rewrite my patch.
> If we have to do something magic in the build system to find `ffi.h`,
won't that break when we install GHC?
No. They used to be installed into {{{$(ghcheaderdir)}}} i.e. the same
directory as {{{Rts.h}}}, until the said bitrot ocurred. So we don't need
any magic in an installed GHC.
> Modifying `SRC_HC_OPTS` in the build system is usually not the right
thing to do - it is for `mk/build.mk` to set, with a default in
`mk/config.mk`. You'll notice that no other `.mk` file in the build
system sets `SRC_HC_OPTS` or `SRC_CC_OPTS`.
Yes... that's what I've concerned about.
--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/5408#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[email protected]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
