Hello, > I propose new coding methods to enhance GLPI (better code, have > tests, so less bugs): > [...]
Two points I'd like to talk about :) 1- And what about a clear GIT worflow? For some projects, I've already used git-flow (http://nvie.com/posts/a-successful-git-branching-model/); mainly because 1/ it suits my needs, and 2/ it comes with a git extension that makes things (really much) simple. Maybe this one would no fit GLPI's needs in terms of worflow (mainly because it does not handle long term support branches - ie. only one stable version could be maintained); but I guess we should adopt at least some workflow rules. 2- Coding standards has not been mentionned yet (if I remember well); but their respects could be added to the "contribution guide". Standardized code is more simple to read, understand and use :) Unfortunately, the rules that have been used until now are very specific (it is not PSR1, and even less PSR2, nor any existing standard provided with phpcs as fas as I can see). To automate CS checks, we'll have to either: - write a specfifc ruleset that suits our needs (a quite big specific work), - or change them to use something existing, that we could adapt for our needs finally (forcing all functions or methods to be correctly documented for example). That would be a quite big job as well, but less specific for instance. Actual coding standards are documented here: https://forge.glpi-project.org/projects/glpi/wiki/CodingStandards Regards, -- Johan _______________________________________________ Glpi-dev mailing list Glpi-dev@gna.org https://mail.gna.org/listinfo/glpi-dev
