On Mon, Nov 16, 2015 at 02:32:35PM +0530, Aravinda wrote:
> Original patch was proper, wondering which patch introduced this issue.
> http://review.gluster.org/#/c/9503/13/glusterfs.spec.in

This seems to have been my fault. The %endif sneaked a few lines up
here:

  http://review.gluster.org/#/c/10803/10/glusterfs.spec.in

Sorry about that, and thanks for fixing is Kaleb!

Niels

> Fixed now: http://review.gluster.org/#/c/12577 and
> http://review.gluster.org/#/c/12578/
> 
> regards
> Aravinda
> 
> On 11/12/2015 12:31 PM, Milind Changire wrote:
> >They are indeed part of the geo-rep sub package ... the package listing (rpm
> >-qlp) says so.
> >
> >But I guess if somebody attempts a server build without geo-replication
> >then the gfind_missing_files will get appended to the %files ganesha
> >section which is defined just above the %files geo-replication section.
> >This needs to be corrected to push the gfind_missing_files inside the
> >%{!?_without_georeplication:1} section under the %files geo-replication
> >section.
> >
> >Need to get gfind_missing_files package ownership confirmed from Aravinda.
> >
> >
> >
> >On Mon, Nov 9, 2015 at 8:03 PM, Kaleb S. KEITHLEY <[email protected]>
> >wrote:
> >
> >>the in-tree glusterfs.spec(.in) has them immediately following the
> >>geo-rep sub-package, but outside the %if ... %endif.
> >>
> >>Are they part of geo-rep? Or something else?
> >>
> >>--
> >>
> >>Kaleb
> >>_______________________________________________
> >>Gluster-devel mailing list
> >>[email protected]
> >>http://www.gluster.org/mailman/listinfo/gluster-devel
> >>
> >
> >
> >_______________________________________________
> >Gluster-devel mailing list
> >[email protected]
> >http://www.gluster.org/mailman/listinfo/gluster-devel
> 

> _______________________________________________
> Gluster-devel mailing list
> [email protected]
> http://www.gluster.org/mailman/listinfo/gluster-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Gluster-devel mailing list
[email protected]
http://www.gluster.org/mailman/listinfo/gluster-devel

Reply via email to