On Tue, Oct 30, 2007 at 10:43:32AM +0100, Udo Giacomozzi wrote: > Hello Sandro, > > Tuesday, October 30, 2007, 10:37:39 AM, you wrote: > SS> If you remember I asked you "do you have setMask in mind" when you > SS> added the new intelligence. > > Yes, my answer was: I don't know much about setMask() :)
Well, now knowing would be easier, just look at mask_test.c or (easier) DrawingApiTest.as. Short explanatin: maskee.setMask(mask) > Uhm... that may be a problem. But in any case the > add_invalidated_bounds() method is strongly related to the display() > method, i.e. instead of calling renderer mask methods and display() of > childs, it calls add_invalidated_bounds() of the childs and handles > the masks internally. > > So, any changes to display() should also be replicated to > add_invalidated_bounds(). Hmm, might be worth to add a comment about > this relationship in both methods. I'll add a TODO item in the DisplayList::add_invalidated_bounds. Another thing I noticed is the tree crawling in DisplayList::display (now I guess that's also in ::add_invalidated_bounds) which sounds suspicious performance-wise. Was thinking maybe we could have two functions: ::display ::renderAsMask to make it smarter (but this is just a blind attempt) --strk; _______________________________________________ Gnash-commit mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-commit
