On Tue, Sep 04, 2007 at 11:48:28AM +0200, Asger Ottar Alstrup wrote: > On 9/4/07, strk <[EMAIL PROTECTED]> wrote: > > mm.. looks like duplicated code though. > > Two lines? Surely, you can't be serious that you want to introduce at > least 10 lines in headers and source files to abstract the duplication > away. The probability of error in those two lines is much less than if > it is abstracted.
Sorry, I must have misread the patch, I tought you were duplicating the whole tag removal thing. > > Actually, could you check wheter .text and .htmlText are proper properties > > or not ? There should be some tests in actionscript.all/TextField.as > > If they are supposed to be proper properties, we should turn them into > > getter/setter more likely. > > Even if they are, these fields are not implemented as properties now. > The patch as it stands is a monotonous improvement. Any further clean > ups can come in later patches. Fine with me, I was just trying to get more contributions :) --strk; _______________________________________________ Gnash-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-dev
