Hi Asger, Thanks very much for the patch. I've committed it to CVS head (with the blessings of strk). As you say it provides an immediate improvement and can be built-upon/refactored as needed later.
Cheers, Ivor --- Asger Ottar Alstrup <[EMAIL PROTECTED]> wrote: > On 9/4/07, strk <[EMAIL PROTECTED]> wrote: > > mm.. looks like duplicated code though. > > Two lines? Surely, you can't be serious that you want to introduce at > least 10 lines in headers and source files to abstract the duplication > away. The probability of error in those two lines is much less than if > it is abstracted. > > > Actually, could you check wheter .text and .htmlText are proper > properties > > or not ? There should be some tests in actionscript.all/TextField.as > > If they are supposed to be proper properties, we should turn them into > > getter/setter more likely. > > Even if they are, these fields are not implemented as properties now. > The patch as it stands is a monotonous improvement. Any further clean > ups can come in later patches. > > > And for sure we should have a single function handling that html strip. > > Where do you want to put this? Over time, the parsing will obviously > have to become more complicated, and change the formatting of > individual characters in the textfield according to the result of > parsing. > > Regards, > Asger > > > _______________________________________________ > Gnash-dev mailing list > [email protected] > http://lists.gnu.org/mailman/listinfo/gnash-dev > ____________________________________________________________________________________ Sick of deleting your inbox? Yahoo!7 Mail has free unlimited storage. http://au.docs.yahoo.com/mail/unlimitedstorage.html _______________________________________________ Gnash-dev mailing list [email protected] http://lists.gnu.org/mailman/listinfo/gnash-dev
