Alex, I was going to merge the Terminator plugin, but JohnG made changes to the official plugins branch. I did a brief code review, and found only two problems: whitespace issues, and it looks like some of the code indexes GNOME Terminal profiles.
John, why do you index GNOME terminal profiles? Are these opened in Terminator? David On Thu, Sep 18, 2008 at 9:52 AM, David Siegel <[EMAIL PROTECTED]> wrote: > For the record, I didn't ignore it -- I totally forgot about it. Please > keep nudging us until we commit your work. > > Thanks, > David > > > On Thu, Sep 18, 2008 at 12:45 AM, JohnnyG <[EMAIL PROTECTED]> wrote: > >> >> I believe my work on terminator support has been languishing: >> >> https://code.launchpad.net/~swfiua/do-plugins/terminator<https://code.launchpad.net/%7Eswfiua/do-plugins/terminator> >> >> There are two options in the above branch: mods to the gnome-terminal >> plugin and a separate terminator plugin. >> >> The latter I produced when Dave questioned the gnome-terminal >> plugin. Sadly, he then ignored it. >> >> John >> >> On Sep 18, 3:35 am, "Alex Launi" <[EMAIL PROTECTED]> wrote: >> > Who needs code reviews or merges? I lost my list, please let me know if >> you >> > have a plugin that needs to make its way into community/main. We love >> > plugins! Launchpad says 0, but my guess is that people aren't doing it >> up LP >> > style. For the future, here is a link that explains how *I'd* like you >> to do >> > it, however if you don't nothing will happen, you plugin just might get >> lost >> > track of (comme-ci!). >> http://do.davebsd.com/wiki/index.php?title=Getting_started_with_writi... >> > >> > -- >> > --Alex Launi >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "GNOME Do" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/gnome-do?hl=en -~----------~----~----~----~------~----~------~--~---
