Hi Nageswara, Thank you very much for the patch! Can you open a bug at https://bugzilla.gnome.org component gnome-shell with this? Our workflow around patches is highly centered in bugzilla, since that's where the code review tool Splinter lives, etc.
One thing I noticed glancing at it quickly is that new code should be using St and CSS ideally; you can look at some of the patches in say https://bugzilla.gnome.org/show_bug.cgi?id=600734 to get an idea of how to use the CSS system (though we don't have a CSS style guide yet). On Sun, Nov 8, 2009 at 1:58 AM, Nageswara <[email protected]> wrote: > > I recently tried gnome-shell on my ubuntu system and liked the overlay > design concept very much. While using the shell, I felt that it would be > better to have window action menu appeared in overview mode also. (when user > right clicks on a window). Later, this menu can be extend to support app > specific menus. Seems reasonable. > So with this idea, I went ahead and opened source and tried changing it. I'm > attaching the patch to this mail. This is not yet completed, just looking > for your suggestions. I couldn't find mutter api to get current state of > window i.e. is_maximized/is_minimized etc., to hide irrelevant options (we > shouldn't show maximize option when the window is already maximized). > similarly, there is no api function to keep window on all workspaces :( If > you ppl know alternative way of doing these things, please let me know. We've been evolving the mutter API on an on-demand basis essentially. It looks like minimized is an internal boolean; making it a GObject property with notification would make sense probably. There was a patch to add many more properties to MetaWindow but I can't find it in bugzilla at the moment. > Similary I've another idea too. When user maximizes a window, how about > merging titlebar of the window with top-panel ? we are already showing > window title in top-panel, why not buttons (I mean minimize, maximize > buttons). That way we can save some screen real estate. For this we may need > to work with mutter folks, not sure. I think it would make sense particularly in constrained screen sizes, and there's been some work on it but I'm not sure offhand of the state. Thanks a lot again for the patch! Let's get it in bugzilla and iterate from there. _______________________________________________ gnome-shell-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/gnome-shell-list
