Hi Alex,
Le vendredi 07 mars 2008, à 12:33 +0100, Alexander Larsson a écrit :
> I'd like request to break the code freeze for two gvfs patches:
>
> 1 - Translate cd media names, like N_("Blank CD-ROM Disc"):
>
> --- hal/ghalmount.c (revision 1602)
> +++ hal/ghalmount.c (working copy)
> @@ -209,9 +209,9 @@
> }
>
> if (is_blank)
> - return disc_data[n].ui_name_blank;
> + return gettext(disc_data[n].ui_name_blank);
> else
> - return disc_data[n].ui_name;
> + return gettext(disc_data[n].ui_name);
> }
Why aren't you using _()? Else, approval 1 of 2.
> 2 - Don't automount gphoto:// volumes. This is problematic,
> as when they are mounted other apps can't access the device.
> Longterm they should ideally use gio to access the files so
> that everyone can share the connection and apps don't need
> gphoto specific code. However, atm the automount is causing
> problem by locking out apps using libgphoto directly.
Looks good to me. Approval 1 of 2.
Vincent
--
Les gens heureux ne sont pas pressés.
_______________________________________________
gnome-vfs-list mailing list
gnome-vfs-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-vfs-list
