Am Freitag, den 07.03.2008, 13:49 +0100 schrieb Alexander Larsson:
> On Fri, 2008-03-07 at 13:02 +0100, Kjartan Maraas wrote:
> > fr., 07.03.2008 kl. 12.51 +0100, skrev Alexander Larsson:
> > > On Fri, 2008-03-07 at 12:43 +0100, Kjartan Maraas wrote:
> > > > fr., 07.03.2008 kl. 12.40 +0100, skrev Vincent Untz:
> > > > > Le vendredi 07 mars 2008, à 12:38 +0100, Alexander Larsson a écrit :
> > > > > > 
> > > > > > On Fri, 2008-03-07 at 12:36 +0100, Vincent Untz wrote:
> > > > > > 
> > > > > > > > --- hal/ghalmount.c     (revision 1602)
> > > > > > > > +++ hal/ghalmount.c     (working copy)
> > > > > > > > @@ -209,9 +209,9 @@
> > > > > > > >      }
> > > > > > > >    
> > > > > > > >    if (is_blank)
> > > > > > > > -    return disc_data[n].ui_name_blank;
> > > > > > > > +    return gettext(disc_data[n].ui_name_blank);
> > > > > > > >    else
> > > > > > > > -    return disc_data[n].ui_name;
> > > > > > > > +    return gettext(disc_data[n].ui_name);
> > > > > > > >  }
> > > > > > > 
> > > > > > > Why aren't you using _()? Else, approval 1 of 2.
> > > > > > 
> > > > > > Wouldn't that mark it for translation?
> > > > > 
> > > > > I think not. It only mark things for translation when they are 
> > > > > constant
> > > > > strings (as in "something") and not when they are variables. At 
> > > > > least, I
> > > > > seriously hope it does this :-)
> > > > > 
> > > > >From gi18n.h:
> > > > #define  _(String) gettext (String)
> > > 
> > > Sure, the question is not what the code does, but how the gettext/pofile
> > > machinery handles it.
> > > 
> > It handles it with _() as well IIRC. I've seen that used in many places
> > and never found such things in the po-files.
> 
> Other places in nautilus use gettext() for this case. I doubt it matters
> either way. Anyway, can i get a 2nd ack?

approval 2 of 2.

andre
-- 
 mailto:[EMAIL PROTECTED] | failed
 http://www.iomc.de/  | http://blogs.gnome.org/aklapper

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

_______________________________________________
gnome-vfs-list mailing list
gnome-vfs-list@gnome.org
http://mail.gnome.org/mailman/listinfo/gnome-vfs-list

Reply via email to