Hi, Derek Atkins <[EMAIL PROTECTED]> wrote: > Quoting Christian Stimming <[EMAIL PROTECTED]>: > > Before applying this, I would like to hear Andreas' take on this: You > > intentionally added only the printing of the lines that should be added > > to install.sh, instead of directly writing into that file. Was there a > > specific reason for doing so? Because Harold's proposal basically says > > he prefers to have those lines written to the file directly. > > Right now we don't modify /etc/profile.d/installer by hand at all. > We /JUST/ ask the user to make the changes. I agree that this is what > we should continue to do, so I agree with Andreas to not modify > /etc/profile.d ourselves. > > I'll note that some people might not want /etc/profile.d modified > by the build script; they should be allowed to do so on their own.
Seconded. Another point is that we cannot change the running shells environment from a subshell, so newly opened shells would have different environment variables set. I will not like the patch without very good reasons :-) > -derek -- andi5 -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer _______________________________________________ gnucash-devel mailing list [email protected] https://lists.gnucash.org/mailman/listinfo/gnucash-devel
