On Wed, Jul 26, 2023 at 5:50 AM Christopher Lam <[email protected]> wrote:
> On Wed, 26 Jul 2023 at 11:32, john <[email protected]> wrote: > > > Yeah, it's gotten a lot faster since Chris Lam figured out it was > checking > > every transaction for every split in the transaction and fixed it to only > > traverse the transactions once. > > > > This was only 1 part of the speedup: each typical (2 or more splits) > transaction was being scrubbed as many times as they have splits. This was > PR 1651. > The more significant speedup was to eliminate the xaccTransBegin/CommitEdit > before the scrub, and only call them if the transaction needed to be > scrubbed. PR 1654. > Benchmarks: > https://github.com/Gnucash/gnucash/pull/1654#issuecomment-1573876944 > _______________________________________________ > Wow! That's QUITE a speed up; I remember it taking 30 seconds to a minute or longer, and now it's so fast, it's almost unnoticeable. Note: It may be useful to add some kind of notice that the check has completed... I wasn't aware of the speedup, and thought it was throwing an error and aborting. _________________________________ Richard Losey [email protected] Micah 6:8 _______________________________________________ gnucash-user mailing list [email protected] To update your subscription preferences or to unsubscribe: https://lists.gnucash.org/mailman/listinfo/gnucash-user ----- Please remember to CC this list on all your replies. You can do this by using Reply-To-List or Reply-All.
