Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/1976 was reviewed by Daiki Ueno
-- Daiki Ueno started a new discussion on lib/includes/gnutls/gnutls.h.in: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2802493624 > + GNUTLS_HPKE_MODE_PSK, > + GNUTLS_HPKE_MODE_PSK_AUTH, > +} gnutls_hpke_mode_t; This enum is not used anywhere. Shall we drop it? -- Daiki Ueno started a new discussion on lib/nettle/hpke/hpke-hkdf.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2802493636 > +#include "hpke-internal.h" > + > +#include "ecc-internal.h" I haven't closely looked at this code, but it seems "ecc-internal.h" is only used for accessing `ecc->q`, so we can reuse it. I guess we could simply embed the [constants](https://www.rfc-editor.org/rfc/rfc9180.html#section-7.1.3) defined in the RFC instead. -- Daiki Ueno started a new discussion on lib/includes/gnutls/abstract.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2802493640 > +int gnutls_privkey_decap_with_psk(const gnutls_privkey_t skR, > + const gnutls_datum_t psk, > + const gnutls_pk_encapsulate_flags_t flags, We usually put the `flags` argument last. -- Daiki Ueno started a new discussion on lib/nettle/hpke/hpke-gmp.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2802493647 > + assert(n > 0); > + > + mp_get_memory_functions(&alloc_func, NULL, NULL); This probably interfere with the other parts of GnuTLS, as it also uses it. -- Daiki Ueno started a new discussion on lib/nettle/hpke/nettle-alloca.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976#note_2802493648 > +/* nettle-internal.h lib/nettle/int/nettle-internal.h has these definitions already. -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/1976 You're receiving this email because of your account on gitlab.com.
_______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel
