On 10/22/06, André Detsch <[EMAIL PROTECTED]> wrote:
> Patch looks fine, but I would prefer to commit it right after 013 release.
> Ok?

In this case, the best to do is to keep the patch posted as an open bug at Bugs.

-- Hisham

> On 10/22/06, Jonas Karlsson <[EMAIL PROTECTED]> wrote:
> > On Sun, 22 Oct 2006 19:27:07 +0200, André Detsch <[EMAIL PROTECTED]> wrote:
> >
> > > Only --force (-f) is working. Looking at the code, it seems that the
> > > introduction of --force has made the -c option being ignored.
> > >
> > My fault. Forgot that checks against passed options has to be done with
> > the functions in OptionParser, and the not against the corresponding
> > variable names.
> > Suggested patch:
> >
> > diff -u -r1.30 SymlinkProgram
> > --- SymlinkProgram      24 Sep 2006 11:12:11 -0000      1.30
> > +++ SymlinkProgram      22 Oct 2006 18:45:25 -0000
> > @@ -47,7 +47,8 @@
> >   linkshared=`Entry "shared"`
> >   linkwrappers=`Entry "wrappers"`
> >
> > -Boolean "force" && conflict="overwrite"
> > +[ `Boolean "force"` -o `Entry "conflict"`=="overwrite" ] &&
> > conflict="overwrite"
> > +
> >
> ################################################################################
> >
> >   # Creates links from one directory into another.
> >
> > > On 10/22/06, Jonatan Liljedahl <[EMAIL PROTECTED]> wrote:
> > >> SymlinkProgram -c overwrite doesn't work. It doesn't overwrite...
> > >>
> >
> > --
> > /Jonas
> >
> > Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
> > _______________________________________________
> > gobolinux-devel mailing list
> > gobolinux-devel@lists.gobolinux.org
> > http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
> >
>
>
> --
> Andre Detsch
> _______________________________________________
> gobolinux-devel mailing list
> gobolinux-devel@lists.gobolinux.org
> http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
>
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel

Reply via email to