On Jan 6, 2008 10:45 PM, Carlo Calica <[EMAIL PROTECTED]> wrote: > On 1/6/08, Jonas Karlsson <[EMAIL PROTECTED]> wrote: > > > > Add a check so that get_next_system_id() doesn't loop above 1000? > > yep
Done. > > A warning should be issued if adding the user/group fails. > > One should be able to specify $HOME location for the user. > > 'useradd' and 'groupadd' have to be wrapped with $sudo_exec. > > SymlinkProgram does a Verify_Superuser but still needed for Rootless. > Is sudo a fair assumption for Rootless? I'd say yes, as some programs might not work after installed without passing through special operations (adduser, chown, chmod). > > Maybe add code in RemoveProgram and SymlinkProgram to remove > > groups/users when an application is removed. > > I'd say no. Some data may remain on disk after removal. If > reinstalled, that data should be accessible, with same uid/gid. > Granted, that isn't a common case. Good point. I prefer to don't touch that now and consider these operations as "unmanaged". I've added these extra boundaries checks, improved get_next_system_id() and added some comments to make our policies clear. Does it look good enough for commit? -- Lucas powered by /dev/dsp
Scripts-Requirements.patch
Description: Binary data
_______________________________________________ gobolinux-devel mailing list gobolinux-devel@lists.gobolinux.org http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
