Jonas Karlsson wrote:
> On 12/05/2008, Daniele Maccari <[EMAIL PROTECTED]> wrote:
>
>> Michael Homer wrote:
>> >
>> > I'll let Hisham speak for himself, but I think the general point he's
>> > making (and the one that's been discussed before) is that in general,
>> > running something in between configure and make is a hack to fix
>> > something that's been misconfigured (e.g., patching a makefile
>> > post-generation). That sort of situation is better handled by patching
>> > configure.ac to fix the problem at the root, which will probably keep
>> > working between releases and be more robust.
>> >
>>
>> Although I agree on this point, I also think that we should trust
>> recipes authors a little more. In other words, I believe adding features
>> to our recipes system, even if only usable by specific type recipes,
>> should just be seen as a "handy" addition, which could or could not be
>> used when necessary. It's up to the recipe writer, hence, to not misuse
>> what we provide him with to best accomplish what he need to.
>> For example in the sun-jdk recipe the pre_patch hook is used to run the
>> license and unpack the package, though no patch is actually present. So
>> I think this could be seen as a misuse of the pre_patch hook (which the
>> docs tell should not be executed when no patches are present, but this
>> doesn't seem to reflect reality).
>>
>> Also, as you said, OOo has a very uncommon build procedure, for which I
>> really don't see any clean way to perform it without this post_configure
>> hook. But I'm surely not that deep into Compile internals as Hisham or
>> any other dev is.
>>
>>
> If the build system doesn't work with configure, why make it
> recipe_type=configure? IIrc we did have a discussion between configure
> and autoconf recipe type, but we decided on configure.
> So make OOo recipe_type=makefile and add function calls to pre_make,
> just like the Qt or Perl recipes do.
>
>
Well, it actually uses configure to find out what to use, but then it
needs its own bootstrap script to build itself. Also, its configure has
a lot of options, handling which would be really hard without the
configure_options array.
_______________________________________________
gobolinux-devel mailing list
gobolinux-devel@lists.gobolinux.org
http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
